Revert 44714 manually #47824
Merged
Revert 44714 manually #47824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
kind/api-change
mbohlool
force-pushed
the
revert2
branch
3 times, most recently
from
7c7688d
to
effb54e
Compare
|
/test pull-kubernetes-e2e-gce-etcd3 |
|
Probably we should nuke the release note in the original PR and this PR. |
|
The manual changes look good. The original PR touched 120 files, this one touched 117 files, wonder what are missed. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/release-note-none |
k8s-ci-robot
added
release-note-none
|
/lgtm xref: #38120 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caesarxuchao, dchen1107, mbohlool Associated issue: 44714 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
This is blocking lifting code freeze, so apply the label. |
|
Automatic merge from submit-queue (batch tested with PRs 47851, 47824, 47858, 46099) |
Closed
dims
pushed a commit
to dims/kubernetes
that referenced
this pull request
Feb 8, 2018
Automatic merge from submit-queue (batch tested with PRs 47851, 47824, 47858, 46099) Revert 44714 manually kubernetes#44714 broke backward compatibility for old swagger spec that kubectl still uses. The decision on kubernetes#47448 was to revert this change but the change was not automatically revertible. Here I semi-manually remove all references to UnixUserID and UnixGroupID and updated generated files accordingly. Please wait for tests to pass then review that as there may still be tests that are failing. Fixes kubernetes#47448 Adding release note just because the original PR has a release note. If possible, we should remove both release notes as they cancel each other. **Release note**: (removed by caesarxuchao) UnixUserID and UnixGroupID is reverted back as int64 to keep backward compatibility.
k8s-github-robot
pushed a commit
that referenced
this pull request
May 4, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Use single struct in internal type to reduce difference with external type **What this PR does / why we need it**: This PR reduces the differences between internal and external types by removing leftovers after revert of one of the changes. **Special notes for your reviewer**: We had `IDRange` in both types prior 9440a68 commit (#44714) that splitted it into `UserIDRange`/`GroupIDRange`. Later, in c91a12d commit (#47824) we had to revert these changes because they broke backward compatibility but `UserIDRange`/`GroupIDRange` structs were left in the internal type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44714 broke backward compatibility for old swagger spec that kubectl still uses. The decision on #47448 was to revert this change but the change was not automatically revertible. Here I semi-manually remove all references to UnixUserID and UnixGroupID and updated generated files accordingly.
Please wait for tests to pass then review that as there may still be tests that are failing.
Fixes #47448
Adding release note just because the original PR has a release note. If possible, we should remove both release notes as they cancel each other.
Release note: (removed by caesarxuchao)
UnixUserID and UnixGroupID is reverted back as int64 to keep backward compatibility.